backport: 19754 and necessary pre-reqs #4880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please rebase. |
PastaPastaPasta
force-pushed
the
backports-19754
branch
from
97fe597 to
872c730
Compare
UdjinM6
requested changes
Jun 16, 2022
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
pls see https://github.com/UdjinM6/dash/commits/pr4880 for some fixes (test_dash_qt still fails)
|
This pull request has conflicts, please rebase. |
kwvg
requested changes
Jun 21, 2022
Collaborator
kwvg
left a comment
kwvg
left a comment
There was a problem hiding this comment.
See https://github.com/kittywhiskers/dash/commits/dash4880, rebased over develop, squashed Udjin's fixes and resolved test_dash_qt failure. Also resolved incorrect address bug caused by querying GetDataDir() instead of GetWalletDir().
Co-authored-by: UdjinM6 <[email protected]>
…storage Co-authored-by: UdjinM6 <[email protected]>
…options Co-authored-by: UdjinM6 <[email protected]>
… node.h Co-authored-by: UdjinM6 <[email protected]>
PastaPastaPasta
force-pushed
the
backports-19754
branch
from
872c730 to
fcbe2c7
Compare
UdjinM6
requested changes
Jun 23, 2022
PastaPastaPasta
force-pushed
the
backports-19754
branch
from
fcbe2c7 to
6c65e22
Compare
UdjinM6
requested changes
Jul 1, 2022
… startup Co-authored-by: UdjinM6 <[email protected]>
PastaPastaPasta
force-pushed
the
backports-19754
branch
from
6c65e22 to
9021e3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.